Deprecate the Annotation interface
#10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
derrabus
force-pushed
the
deprecate/annotation-interface
branch
from
ef380ae to
ead2f90
Compare
derrabus
commented
Oct 26, 2022
| @@ -39,6 +39,8 @@ | |||
| <referencedClass name="Doctrine\ORM\Tools\Console\Command\GenerateRepositoriesCommand"/> | |||
| <referencedClass name="Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper"/> | |||
| <referencedClass name="Doctrine\ORM\Tools\Console\EntityManagerProvider\HelperSetManagerProvider"/> | |||
| <!-- https://github.com/vimeo/psalm/issues/8617 --> | |||
| <referencedClass name="Doctrine\ORM\Mapping\Annotation"/> | |||
There was a problem hiding this comment.
The interface is reported as a class when used in generics. I've created vimeo/psalm#8617 to track this issue.
greg0ire
reviewed
Oct 26, 2022
| namespace Doctrine\ORM\Mapping; | ||
|
|
||
| /** A marker interface for mapping attributes. */ | ||
| interface MappingAttribute extends Annotation |
There was a problem hiding this comment.
Why did you name it MappingAttribute and not just Attribute? It is already inside a Mapping namespace.
There was a problem hiding this comment.
Because literally all classes that implement this interface also have an attribute attached to them named Attribute and I didn't want to screw up the imports everywhere. I also wanted the name of the marker interface to be a bit more specific. After all, it's not just an arbitrary attribute, it's one that we use to configure mapping information.
greg0ire
approved these changes
Oct 26, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 31, 2022
* 2.14.x: Deprecate the Annotation interface (doctrine#10178) Bump CI to PHP 8.2 and latest database versions (doctrine#10180) Remove reference to deprecated DriverChain from docs (doctrine#10179)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we remove the support for annotations, having a marker interface named
Annotationfor our attribute classes seems weird. Let's rename it.