Skip to content

Commit

Permalink
Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker(…
Browse files Browse the repository at this point in the history
…)` method

We use this method only from within one of our own test cases, and I don't see how it would be useful to anybody else outside – it has to be called on the `Parser` instance which exists internally in the `Query` only.

Deprecating and removing it in 3.x allows for a slight simplification in the `Parser` there, since we do no longer need the field (it can be a local variable).
  • Loading branch information
mpdude committed Oct 9, 2024
1 parent 91709c1 commit f3c1d71
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/Query/Parser.php
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,13 @@ public function __construct(Query $query)
*/
public function setCustomOutputTreeWalker($className)
{
Deprecation::trigger(
'doctrine/orm',
'https://github.com/doctrine/orm/pull/11641',
'%s is deprecated, set the output walker class in a query hint instead',
__METHOD__

Check warning on line 207 in src/Query/Parser.php

View check run for this annotation

Codecov / codecov/patch

src/Query/Parser.php#L203-L207

Added lines #L203 - L207 were not covered by tests
);

$this->customOutputWalker = $className;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Tests/ORM/Query/LanguageRecognitionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function parseDql(string $dql, array $hints = []): ParserResult
$parser = new Query\Parser($query);

// We do NOT test SQL output here. That only unnecessarily slows down the tests!
$parser->setCustomOutputTreeWalker(NullSqlWalker::class);
$query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, NullSqlWalker::class);

return $parser->parse();
}
Expand Down

0 comments on commit f3c1d71

Please sign in to comment.