Add missing return statements to Command:configure methods

doctrine · Mar 5, 2023 · e28dee0 · e28dee0
1 parent a28e2d8
commit e28dee0
Show file tree

Hide file tree

Showing 19 changed files with 18 additions and 116 deletions.
diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/CollectionRegionCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/CollectionRegionCommand.php
@@ -20,9 +20,7 @@
  */
 class CollectionRegionCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:region:collection')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/EntityRegionCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/EntityRegionCommand.php
@@ -20,9 +20,7 @@
  */
 class EntityRegionCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:region:entity')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php
@@ -18,9 +18,7 @@
  */
 class MetadataCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:metadata')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php
@@ -27,9 +27,7 @@
  */
 class QueryCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:query')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryRegionCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryRegionCommand.php
@@ -20,9 +20,7 @@
  */
 class QueryRegionCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:region:query')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php
@@ -29,9 +29,7 @@
  */
 class ResultCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:clear-cache:result')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ConvertDoctrine1SchemaCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ConvertDoctrine1SchemaCommand.php
@@ -72,9 +72,7 @@ public function setMetadataExporter(ClassMetadataExporter $metadataExporter)
         $this->metadataExporter = $metadataExporter;
     }
 
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:convert-d1-schema')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php
@@ -37,9 +37,7 @@
  */
 class ConvertMappingCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:convert-mapping')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php
@@ -19,9 +19,7 @@
  */
 class EnsureProductionSettingsCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:ensure-production-settings')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/GenerateEntitiesCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/GenerateEntitiesCommand.php
@@ -28,9 +28,7 @@
  */
 class GenerateEntitiesCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:generate-entities')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/GenerateProxiesCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/GenerateProxiesCommand.php
@@ -26,9 +26,7 @@
  */
 class GenerateProxiesCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:generate-proxies')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/GenerateRepositoriesCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/GenerateRepositoriesCommand.php
@@ -27,9 +27,7 @@
  */
 class GenerateRepositoriesCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:generate-repositories')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/InfoCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/InfoCommand.php
@@ -20,9 +20,7 @@
  */
 class InfoCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:info')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/RunDqlCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/RunDqlCommand.php
@@ -27,9 +27,7 @@
  */
 class RunDqlCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:run-dql')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/CreateCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/CreateCommand.php
@@ -19,9 +19,7 @@
  */
 class CreateCommand extends AbstractCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:schema-tool:create')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/DropCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/DropCommand.php
@@ -20,9 +20,7 @@
  */
 class DropCommand extends AbstractCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:schema-tool:drop')

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/UpdateCommand.php
@@ -24,9 +24,7 @@ class UpdateCommand extends AbstractCommand
     /** @var string */
     protected $name = 'orm:schema-tool:update';
 
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName($this->name)

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php
@@ -20,9 +20,7 @@
  */
 class ValidateSchemaCommand extends AbstractEntityManagerCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    /** @return void */
     protected function configure()
     {
         $this->setName('orm:validate-schema')

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -2541,43 +2541,19 @@
     </UnsafeInstantiation>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/CollectionRegionCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <PossiblyNullReference>
       <code>evictAll</code>
     </PossiblyNullReference>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/EntityRegionCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <PossiblyNullReference>
       <code>evictAll</code>
     </PossiblyNullReference>
   </file>
-  <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/MetadataCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
-  </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryCommand.php">
     <DeprecatedMethod>
       <code>getQueryCacheImpl</code>
     </DeprecatedMethod>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
-  </file>
-  <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/QueryRegionCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
-  </file>
-  <file src="lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/ConvertDoctrine1SchemaCommand.php">
     <ArgumentTypeCoercion>
@@ -2599,9 +2575,6 @@
     <InvalidArgument>
       <code>$metadata</code>
     </InvalidArgument>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php">
     <ArgumentTypeCoercion>
@@ -2613,9 +2586,6 @@
       <code>new DisconnectedClassMetadataFactory()</code>
       <code>new EntityGenerator()</code>
     </DeprecatedClass>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <NoInterfaceProperties>
       <code><![CDATA[$class->name]]></code>
     </NoInterfaceProperties>
@@ -2624,9 +2594,6 @@
     <InvalidDocblock>
       <code>connect</code>
     </InvalidDocblock>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/GenerateEntitiesCommand.php">
     <ArgumentTypeCoercion>
@@ -2636,17 +2603,11 @@
       <code>new DisconnectedClassMetadataFactory()</code>
       <code>new EntityGenerator()</code>
     </DeprecatedClass>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <NoInterfaceProperties>
       <code><![CDATA[$metadata->name]]></code>
     </NoInterfaceProperties>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/GenerateProxiesCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <NoInterfaceProperties>
       <code><![CDATA[$metadata->name]]></code>
     </NoInterfaceProperties>
@@ -2658,17 +2619,11 @@
     <DeprecatedClass>
       <code>new EntityRepositoryGenerator()</code>
     </DeprecatedClass>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <NoInterfaceProperties>
       <code><![CDATA[$metadata->customRepositoryClassName]]></code>
     </NoInterfaceProperties>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/InfoCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <PossiblyNullReference>
       <code>getAllClassNames</code>
     </PossiblyNullReference>
@@ -2685,9 +2640,6 @@
     <DeprecatedClass>
       <code><![CDATA[Debug::dump($resultSet, (int) $input->getOption('depth'), true, false)]]></code>
     </DeprecatedClass>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/AbstractCommand.php">
     <InvalidNullableReturnType>
@@ -2702,19 +2654,13 @@
       <code>$metadatas</code>
       <code>$metadatas</code>
     </ArgumentTypeCoercion>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
   </file>
   <file src="lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/DropCommand.php">
     <ArgumentTypeCoercion>
       <code>$metadatas</code>
       <code>$metadatas</code>
       <code>$metadatas</code>
     </ArgumentTypeCoercion>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <PossiblyNullArgument>
       <code><![CDATA[$this->getName()]]></code>
       <code><![CDATA[$this->getName()]]></code>
@@ -2724,19 +2670,11 @@
     <ArgumentTypeCoercion>
       <code>$metadatas</code>
     </ArgumentTypeCoercion>
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
     <PossiblyNullArgument>
       <code><![CDATA[$this->getName()]]></code>
       <code><![CDATA[$this->getName()]]></code>
     </PossiblyNullArgument>
   </file>
-  <file src="lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php">
-    <MissingReturnType>
-      <code>configure</code>
-    </MissingReturnType>
-  </file>
   <file src="lib/Doctrine/ORM/Tools/Console/MetadataFilter.php">
     <InvalidArgument>
       <code>new ArrayIterator($metadatas)</code>