Fix CS violations

doctrine · Jan 28, 2024 · 9f085f8 · 9f085f8
1 parent 04b89f5
commit 9f085f8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/lib/Doctrine/ORM/Query/Exec/FinalizedSelectExecutor.php b/lib/Doctrine/ORM/Query/Exec/FinalizedSelectExecutor.php
@@ -6,6 +6,7 @@
 
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Result;
+use Doctrine\DBAL\Types\Type;
 
 /**
  * SQL executor for a given, final, single SELECT SQL query
@@ -19,6 +20,10 @@ public function __construct(string $sql)
         $this->sqlStatements = $sql;
     }
 
+    /**
+     * @param list<mixed>|array<string, mixed>                                     $params
+     * @param array<int, int|string|Type|null>|array<string, int|string|Type|null> $types
+     */
     public function execute(Connection $conn, array $params, array $types): Result
     {
         return $conn->executeQuery($this->getSqlStatements(), $params, $types, $this->queryCacheProfile);

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH11112Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH11112Test.php
@@ -26,16 +26,16 @@ public function testSimpleQueryHasLimitAndOffsetApplied(): void
 
         $query->setMaxResults(10);
         $query->setFirstResult(20);
-        $sql10_20 = $query->getSQL();
+        $sqlMax10First20 = $query->getSQL();
 
         $query->setMaxResults(30);
         $query->setFirstResult(40);
-        $sql30_40 = $query->getSQL();
+        $sqlMax30First40 = $query->getSQL();
 
         // The SQL is platform specific and may even be something with outer SELECTS being added. So,
         // derive the expected value at runtime through the platform.
-        self::assertSame($platform->modifyLimitQuery($originalSql, 10, 20), $sql10_20);
-        self::assertSame($platform->modifyLimitQuery($originalSql, 30, 40), $sql30_40);
+        self::assertSame($platform->modifyLimitQuery($originalSql, 10, 20), $sqlMax10First20);
+        self::assertSame($platform->modifyLimitQuery($originalSql, 30, 40), $sqlMax30First40);
 
         $cacheEntries = self::$queryCache->getValues();
         self::assertCount(1, $cacheEntries);