Merge pull request #11519 from greg0ire/remove-db-driver

Remove DatabaseDriver

UPGRADE.md

@@ -1,5 +1,9 @@
 # Upgrade to 4.0
 
+## Remove `DatabaseDriver`
+
+The class `Doctrine\ORM\Mapping\Driver\DatabaseDriver` is removed.
+
 ## Remove the `NotSupported` exception
 
 The class `Doctrine\ORM\Exception\NotSupported` has been removed without replacement.

psalm-baseline.xml

@@ -449,23 +449,6 @@
       <code><![CDATA[new ReflectionClass($metadata->name)]]></code>
     </TypeDoesNotContainNull>
   </file>
-  <file src="src/Mapping/Driver/DatabaseDriver.php">
-    <DocblockTypeContradiction>
-      <code><![CDATA[$metadata instanceof ClassMetadata]]></code>
-    </DocblockTypeContradiction>
-    <MoreSpecificImplementedParamType>
-      <code><![CDATA[$metadata]]></code>
-    </MoreSpecificImplementedParamType>
-    <PossiblyNullArrayAccess>
-      <code><![CDATA[$this->tables[$tableName]]]></code>
-      <code><![CDATA[$this->tables[$tableName]]]></code>
-    </PossiblyNullArrayAccess>
-    <PossiblyNullReference>
-      <code><![CDATA[getColumns]]></code>
-      <code><![CDATA[getColumns]]></code>
-      <code><![CDATA[getIndexes]]></code>
-    </PossiblyNullReference>
-  </file>
   <file src="src/Mapping/Driver/SimplifiedXmlDriver.php">
     <MissingParamType>
       <code><![CDATA[$fileExtension]]></code>

psalm.xml

@@ -78,18 +78,6 @@
                 <file name="src/Mapping/ClassMetadataFactory.php"/>
             </errorLevel>
         </InvalidArrayAssignment>
-        <LessSpecificReturnStatement>
-            <errorLevel type="suppress">
-                <!-- In DBAL 4, column precision is nullable. See https://github.com/doctrine/dbal/pull/3511 -->
-                <file name="src/Mapping/Driver/DatabaseDriver.php"/>
-            </errorLevel>
-        </LessSpecificReturnStatement>
-        <MoreSpecificReturnType>
-            <errorLevel type="suppress">
-                <!-- In DBAL 4, the default column value is mixed. See https://github.com/doctrine/dbal/pull/3511 -->
-                <file name="src/Mapping/Driver/DatabaseDriver.php"/>
-            </errorLevel>
-        </MoreSpecificReturnType>
         <InvalidReturnType>
             <errorLevel type="suppress">
                 <!-- https://github.com/vimeo/psalm/issues/8819 -->