Skip to content

Commit

Permalink
Merge pull request #11302 from greg0ire/3.0.x
Browse files Browse the repository at this point in the history
Merge 2.18.x up into 3.0.x
  • Loading branch information
greg0ire authored Feb 24, 2024
2 parents 2a250b5 + 54cd700 commit 3907872
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,6 @@ parameters:
count: 1
path: src/EntityRepository.php

-
message: "#^Method Doctrine\\\\ORM\\\\Mapping\\\\ClassMetadata\\:\\:fullyQualifiedClassName\\(\\) should return class\\-string\\|null but returns string\\|null\\.$#"
count: 1
path: src/Mapping/ClassMetadata.php

-
message: "#^If condition is always true\\.$#"
count: 1
Expand Down
9 changes: 0 additions & 9 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,7 @@
</InvalidNullableReturnType>
<InvalidPropertyAssignmentValue>
<code>$definition</code>
<code><![CDATA[$this->subClasses]]></code>
</InvalidPropertyAssignmentValue>
<LessSpecificReturnStatement>
<code>$className</code>
<code>$className</code>
<code><![CDATA[$this->namespace . '\\' . $className]]></code>
</LessSpecificReturnStatement>
<MoreSpecificReturnType>
<code>class-string|null</code>
</MoreSpecificReturnType>
<NullableReturnStatement>
<code><![CDATA[$this->reflClass]]></code>
</NullableReturnStatement>
Expand Down
5 changes: 1 addition & 4 deletions src/Mapping/ClassMetadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -2464,10 +2464,7 @@ public function getAssociationMappedByTargetField(string $assocName): string
return $assoc->mappedBy;
}

/**
* @return string|null null if the input value is null
* @psalm-return class-string|null
*/
/** @return string|null null if the input value is null */
public function fullyQualifiedClassName(string|null $className): string|null
{
if (empty($className)) {
Expand Down

0 comments on commit 3907872

Please sign in to comment.