This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Add expr method to aggregation expression object #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
aggregation-expr
branch
from
e56404e to
20bc999
Compare
|
LGTM. The similar name is unfortunate but I think it's worth keeping this consistent with the Query API. |
alcaeus
added a commit
that referenced
this pull request
Mar 17, 2016
Add expr method to aggregation expression object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
expr()method to the expression object the same way it is already available in the builder. This is helpful when needing to create a fresh expression object (to be nested inside) without having access to the actual aggregation builder.This may be confusing due to the similarity to the
expression()method that already exists (which can be used to apply an expression previously created withexpr()) but I can't come up with any more meaningful name.