Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

added missing initialize calls to prevents usage of null objects #140

Closed
wants to merge 2 commits into from

Conversation

tecbot
Copy link
Contributor

@tecbot tecbot commented Oct 9, 2013

No description provided.

@jmikola
Copy link
Member

jmikola commented Oct 9, 2013

@tecbot: There appear to be a few test failures. Can you fix those in this PR? Otherwise, I'll try to get to them myself tomorrow.

@tecbot
Copy link
Contributor Author

tecbot commented Oct 9, 2013

@jmikola i fixed the test case.

In our system we have a very mystery bug which make no sense to me but we have fixed it with this change: lovoo@b367b88
I can not explain it to me. Do you have any idea?

@jmikola
Copy link
Member

jmikola commented Oct 11, 2013

@tecbot: That could be related to the legacy MONGO_METHOD macros we use in the driver. These will hopefully be refactored out by 1.5 -- it's a high priority for us. See comments in #138 for more context.

Can you create a PHP snippet that reproduces the error, along with the exact driver and doctrine/mongodb versions in use? Also, does that error only appear after you added the initalize() calls in this PR?

@tecbot
Copy link
Contributor Author

tecbot commented Oct 14, 2013

@jmikola Yes, it's related to the issue.

I can't create a snippet which reproduces the problem because it's happen not all the time and only on one site of our application but I can say that it happens only in CLI mode not with fpm. The error was also before the PR. We use PHP 5.4.10, doctrine/mongodb lovoo@b367b88 and mongo php driver 1.4.1

jmikola added a commit that referenced this pull request Oct 16, 2013
@jmikola
Copy link
Member

jmikola commented Oct 16, 2013

@tecbot: Merged your PR in fc2da50.

Unfortunately, there's no general solution for the MONGO_METHOD issue until we refactor the driver internals. I'm also not sure why this just started showing up as a problem for folks in the last couple of months. In the meantime, the you can use workarounds such as doctrine/mongodb lovoo@b367b88 or NOP function calls to avoid the crashes.

@jmikola jmikola closed this Oct 16, 2013
@jmikola
Copy link
Member

jmikola commented Jul 30, 2014

@tecbot: Just wanted to follow up on your "mystery bug". It was indeed a driver bug and should be fixed in today's 1.5.5 release (see: PHP-722).

@tecbot
Copy link
Contributor Author

tecbot commented Jul 30, 2014

@jmikola Yeah!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants