This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Command method refactoring #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the test back to the unit test suite, since it didn't need to be a functional test.
Currently, this constraint is only used in QueryTest
This avoids an issue with an API change in the driver and makes the group() method more consistent with other command wrappers.
The group command seemed to require this, but there is no harm in doing it for all command options that are expected to be documents.
Before PHP 5.4, checking a string offset on a string variable might return true. Avoid this by expecting an array before we check anything. See: http://php.net/manual/en/function.isset.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
group()now returns an ArrayIterator of its actual results -- not the full command response. See ArrayIterator should also store the full command result #125 for an outstanding feature so ArrayIterator can ultimately include the full command response, too.mapReduce()options are prepared as MongoCode objects (where applicable)mapReduce().