Use attributes in tests #2596
Merged
Use attributes in tests #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
use_attributes_in_tests
branch
2 times, most recently
from
2a9eb8a
to
3cd19d1
Compare
franmomu
force-pushed
the
use_attributes_in_tests
branch
2 times, most recently
from
e5d2ddd
to
36f56a8
Compare
GromNaN
reviewed
Jan 4, 2024
franmomu
force-pushed
the
use_attributes_in_tests
branch
2 times, most recently
from
b2c84e9
to
37b6a10
Compare
GromNaN
approved these changes
Mar 5, 2024
| * | ||
| * @var string|null | ||
| */ | ||
| /** @var string|null */ |
There was a problem hiding this comment.
Note for later, we can use typed properties.
Thanks, I didn't notice about those files.
I don't remember 😞 after rectorphp/rector-doctrine#239 I think it was not so much work |
SenseException
approved these changes
Mar 5, 2024
franmomu
force-pushed
the
use_attributes_in_tests
branch
from
37b6a10
to
a0c806f
Compare
alcaeus
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes most of the annotations for attributes since our minimum PHP version is 8.1, the tests changed are the ones relying on
BaseTestCase::createMetadataDriverImpl()This builds on top of #2502 to make sure it works fine.
I've used rector with some manual adjustments.