-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PHPUnit 10 #2564
Use PHPUnit 10 #2564
Conversation
I'm surprised so little had to be done :) One thing that is off though is number of tests executed: This PR's PHP 8.1, Server 6.0, highest executed 2646 tests Am i looking correctly that there is a test that got lost somewhere? |
Actually there's a chance that PHPUnit's deprecation was counted towards number of tests:
but that be weird decision from PHPUnit's team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franmomu feel free to merge once you decide whether my previous comment makes sense or no :)
Good catch! it was my fault in https://github.com/doctrine/mongodb-odm/pull/2564/files#diff-62b86ab419dbc39877816e5c1f489b8fa4110e14bb395c2ba9f7cd961720ef60L13-L17 /**
* @testWith ["groups"]
* ["groupsSimple"]
*/ was changed to #[TestWith(['groups', 'groupsSimple'])] instead of #[TestWith(['groups'])]
#[TestWith(['groupsSimple'])] |
* 2.6.x: (30 commits) Remove API link from README Aggregation uses CursorInterface instead of Cursor Deprecate legacy commit options (#2578) Improve handling of circular type reference errors in Phpstan Add missing phpdoc Fix return type for overridden methods Fix phpstan errors Add sort operator to $search stage Bump actions/upload-artifact from 2 to 3 (#2572) Implement ObjectManager::isUninitializedObject (#2569) Use PHPUnit 10 (#2564) Test Symfony 7 Support Symfony 7 by adding return types conditionally PHPCS is now happy with new syntax Stop suppressing UndefinedAttributeClass Drop support for old symfony components ReferenceMany: insert an empty array feat: Symfony 7 support Remove unusable Match classes Require PHP 8.1 ...
* 2.6.x: (32 commits) Deprecate DocumentRepository::clear (#2584) Support minDistance and maxDistance options for $near and $nearSphere operators (#2583) Remove API link from README Aggregation uses CursorInterface instead of Cursor Deprecate legacy commit options (#2578) Improve handling of circular type reference errors in Phpstan Add missing phpdoc Fix return type for overridden methods Fix phpstan errors Add sort operator to $search stage Bump actions/upload-artifact from 2 to 3 (#2572) Implement ObjectManager::isUninitializedObject (#2569) Use PHPUnit 10 (#2564) Test Symfony 7 Support Symfony 7 by adding return types conditionally PHPCS is now happy with new syntax Stop suppressing UndefinedAttributeClass Drop support for old symfony components ReferenceMany: insert an empty array feat: Symfony 7 support ...
Closes #2509
Since we are using PHP 8.1, we don't need PHPUnit 9 anymore, I've installed rector locally and replaced annotations with attributes.