Fix psalm build #2525
Merged
Fix psalm build #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
fix_psalm_build
branch
from
7f50a91
to
5a8b992
Compare
These new errors are because a bug in psalm with get_class see vimeo/psalm#9607, they will be gone once we use ::class
franmomu
force-pushed
the
fix_psalm_build
branch
from
5a8b992
to
6c94ac4
Compare
malarzm
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #2512 some new errors appeared I guess because PHPUnit added some assertions.
This PR has some of the changes done in #2519 and also ignores some errors related to vimeo/psalm#9607, that are fixed in
2.6.xbecauseget_classwas removed in #2515 when dropping support for PHP 7.4