fix an error in the XML schema #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Sep 26, 2019
rieschl
force-pushed
the
fix-invalid-xml-element-type
branch
from
30bf6c1 to
7857497
Compare
rieschl
force-pushed
the
fix-invalid-xml-element-type
branch
from
7857497 to
85b8a06
Compare
malarzm
approved these changes
Sep 26, 2019
|
Thanks a lot @rieschl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small bubu in the XML mapping schema file caused
\DOMDocument::schemaValidateto fail and\Doctrine\ODM\MongoDB\Mapping\Driver\XmlDriver::validateSchematherefore triggers a deprecation warning.This is already fixed in the
2.0.0-RC2branch.