Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command example to create a capped collection #2065

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

melkamar
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues

Summary

This PR adds the command to use when using Doctrine with Symfony to create a capped collection.

I spent some time on debugging what exactly needs to be done to have Doctrine listen to the capped collection configuration and it was missing from the documentation.

@alcaeus alcaeus changed the base branch from 1.2.x to 1.3.x October 1, 2019 06:48
@alcaeus alcaeus self-assigned this Oct 1, 2019
@alcaeus alcaeus added this to the 1.3.2 milestone Oct 1, 2019
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - can you please make the suggested changes? Thanks!

docs/en/reference/capped-collections.rst Outdated Show resolved Hide resolved
docs/en/reference/capped-collections.rst Outdated Show resolved Hide resolved
docs/en/reference/capped-collections.rst Outdated Show resolved Hide resolved
@melkamar
Copy link
Contributor Author

melkamar commented Oct 1, 2019

Applied the suggestions, thanks for them!

@alcaeus
Copy link
Member

alcaeus commented Oct 1, 2019

@melkamar can you squash commits? Happy to merge afterwards!

@alcaeus alcaeus merged commit 82f54b8 into doctrine:1.3.x Oct 2, 2019
@alcaeus
Copy link
Member

alcaeus commented Oct 2, 2019

Thanks @melkamar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants