-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise build configuration #2062
Conversation
e3d64aa
to
f71c795
Compare
f71c795
to
5e2ea07
Compare
@@ -16,32 +16,51 @@ env: | |||
- ADAPTER_VERSION="^1.0.0" | |||
- SERVER_DISTRO=ubuntu1604 | |||
- SERVER_VERSION=4.2.0 | |||
matrix: | |||
- SERVER_VERSION="3.0.15" | |||
- SERVER_VERSION="3.2.22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 and 3.2 are EOLed, is there any reason to test them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver still supports them, which is why I added them to the pipeline. I wouldn't go out of my way to support them, but if we can verify that tests pass without additional work then I'm good for it
5e2ea07
to
d43fcda
Compare
d43fcda
to
99aa219
Compare
99aa219
to
b6c64ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question regarding Xdebug, but LGTM.
php: 7.2 | ||
env: DEPLOYMENT=SHARDED_CLUSTER_RS | ||
before_script: | ||
- mv ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini{.disabled,} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a clever one-liner to rename the xdebug.ini.disabled
INI file to xdebug.ini
?
Would it make sense to add || echo "xdebug not available"
here, as is done in before_install
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this expands to mv .../xdebug.ini.disabled .../xdebug.ini
. In this case, there is no echo
as the next line fails the build if xdebug was not found, providing a more detailed message. The mv
in before_install
disables the xdebug extension if present, printing an info message if it wasn't available to begin with (which is not a failure condition as we don't want it there for most builds).
Summary
This makes the build files for 1.3.x and master more consistent, with master then using this version of the build file and just adding the new code quality stages.