Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax naming rule for index key name #2033

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

rieschl
Copy link
Contributor

@rieschl rieschl commented Jun 12, 2019

Q A
Type improvement
BC Break no

Summary

As discussed in Slack I propose to loosen the index key name from NMTOKEN to string.

TL;DR: Sometimes field names have characters that aren't covered by NMTOKEN and setting an index on such a field becomes impossible. MongoDB has no problems with field names or indexes containing arbitrary characters (e.g. a \).

I have no idea how to write a test for that, though.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rieschl!

@alcaeus alcaeus merged commit a418f46 into doctrine:1.3.x Jun 13, 2019
@alcaeus alcaeus self-assigned this Jun 13, 2019
@alcaeus alcaeus added the Bug label Jun 13, 2019
@alcaeus alcaeus added this to the 1.3.0 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants