relax naming rule for index key name #2033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in Slack I propose to loosen the index key name from
NMTOKEN
tostring
.TL;DR: Sometimes field names have characters that aren't covered by NMTOKEN and setting an index on such a field becomes impossible. MongoDB has no problems with field names or indexes containing arbitrary characters (e.g. a
\
).I have no idea how to write a test for that, though.