[1.3] Deprecate proxies from doctrine/common #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
proxy-refactoring-bc-layer
branch
from
f0b2d25 to
502f19e
Compare
alcaeus
changed the title
malarzm
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This drops the proxy classes related to
doctrine/common. Unfortunately we won't be able to provide a BC layer due toocramius/proxy-manager2.0 needing PHP 7.0. To avoid deprecation notices that users can't do anything about (see #1675) I didn't add anytrigger_errorcalls to deprecated interfaces but those could certainly be added toProxyFactoryandProxy.