[1.3] Deprecate passing bool to autogenerate methods. #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Aug 5, 2018
jmikola
reviewed
Aug 15, 2018
| sprintf('Passing boolean value to %s is deprecated, please use constants of %s instead.', __METHOD__, AbstractProxyFactory::class), | ||
| E_USER_DEPRECATED | ||
| ); | ||
| } |
There was a problem hiding this comment.
Would it make sense to convert a bool to the appropriate constant, or is that something you're doing in 2.0? I assume there are more than two possible constant values, which is why we no longer use a boolean here.
There was a problem hiding this comment.
This is currently done in AbstractProxyFactory from doctrine/common: https://github.com/doctrine/common/blob/09140dc44c8fde67cf2c676f6e063406404f032f/lib/Doctrine/Common/Proxy/AbstractProxyFactory.php#L111
We'll have to revisit this deprecation anyways in the course of #1813.
malarzm
force-pushed
the
compat-bool-flags
branch
from
81b3c5d to
d277ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.