[1.3] Deprecate setDefaultRepositoryClassName and getDefaultRepositoryClassName #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Aug 5, 2018
| { | ||
| return isset($this->attributes['defaultRepositoryClassName']) | ||
| ? $this->attributes['defaultRepositoryClassName'] | ||
| return isset($this->attributes['defaultDocumentRepositoryClassName']) |
There was a problem hiding this comment.
This might be a tiny BC break: people May have extended this class and expect to find the attribute with the old name. Not sure if we want to deal with that, just bringing it up.
There was a problem hiding this comment.
Is attributes not private because we currently extended from doctrine/mongodb?
Dealing with this would likely require the new method to ensure both keys are set, but that still wouldn't guarantee they don't get out of sync by some outside forces.
There was a problem hiding this comment.
Is
attributesnot private because we currently extended fromdoctrine/mongodb?
Nevermind. attributes is private, so there's no issue here apart from me not being able to read properly 👍
alcaeus
approved these changes
Aug 17, 2018
malarzm
force-pushed
the
compat-document-repository
branch
from
c37348f to
34fddd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.