Fixes dbref doctrine/mongodb-odm#1635 #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nilz11 thank very much for submitting the patch along with a bug report! I have restarted the failed Travis job but before considering this change I must ask you to include a test that will prevent regression in the future. |
malarzm
requested changes
Aug 29, 2017
|
Added test and tested locally. |
alcaeus
approved these changes
Sep 27, 2017
There was a problem hiding this comment.
LGTM.
@Nilz11 I've rebased this branch on top of 1.1.x and changed the base of the pull request since the bug affects ODM 1.1.
Note that this won't affect the master branch because #1623 changes the entire reference handling, including the bug you fixed here. Nonetheless, I'd still push this into 1.1.7.
malarzm
approved these changes
Sep 27, 2017
|
Thanks @Nilz11! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.