Introduce support for sharded collections #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2016
Closed
|
👍 |
alcaeus
force-pushed
the
sharding-support
branch
from
aa5a539
to
2cb1a58
Compare
| */ | ||
| public function setShardKey(array $keys, array $options = array()) | ||
| { | ||
| if ($this->inheritanceType == self::INHERITANCE_TYPE_SINGLE_COLLECTION && !is_null($this->shardKey)) { |
alcaeus
force-pushed
the
sharding-support
branch
from
e51ed56
to
ba16cf2
Compare
alcaeus
force-pushed
the
sharding-support
branch
2 times, most recently
from
90447c3
to
60e11cd
Compare
| @@ -489,3 +489,54 @@ it on a per query basis: | |||
| $qb->requireIndexes(true); | |||
| $query = $qb->getQuery(); | |||
| $results = $query->execute(); | |||
|
|
|||
| Shard keys | |||
This avoids people having to exclude or include a test group depending on the environment they're running and instead relies on feature detection to run the correct tests.
* Since multi-key indexes are not allowed, we're not allowing collections and many relationships to be used as shard keys * Only allow fields using SET storage strategy being used as shard keys
| * @param object $document | ||
| * @throws \BadMethodCallException | ||
| */ | ||
| protected function processDocumentCollection(SchemaManager $sm, $document) |
There was a problem hiding this comment.
What is the purpose of this and methods below?
There was a problem hiding this comment.
These are defined as abstract in the AbstractCommand class: https://github.com/doctrine/mongodb-odm/blob/b93cae185896cfeeb7c4b6dcef5d9c7da82be1a2/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/AbstractCommand.php#L31..L41
There was a problem hiding this comment.
Oh wow I had no idea we have something like this 👍
|
Good to go once tests are green, yay! 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly builds on top of the work done by @clslrns in #1025. Changes include running travis tests on sharded cluster and some more relaxed error handling to account for different error messages depending on the MongoDB server version used. It also adds documentation for the sharding mapping as well as the
@ShardKeyannotation.This also supersedes the work done in #691 and #325 which have been too long-running to be useful at this stage.
One feature that will be added at a later stage is the support for denormalizing the shard key values in non-simple references; this is not required but can greatly improve query times when fetching references on a sharded collection. This will be another PR as I'm waiting for #1349 to finalize the changes made to simple/full references.
TODO:
incrementstrategy are excluded from shard keys. While this is technically a valid solution it might make more sense to just not update these fields in the query builder instead of throwing an error in the mapping.Store shard key values along with dbRef objects (waiting on storeAs option for references #1349)