Allow expressions as partition in $fill stage

doctrine · Mar 23, 2023 · 77d5827 · 77d5827
1 parent e517015
commit 77d5827
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Fill.php b/lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Fill.php
@@ -86,7 +86,9 @@ public function getExpression(): array
         $params = (object) [];
 
         if ($this->partitionBy) {
-            $params->partitionBy = $this->partitionBy;
+            $params->partitionBy = $this->partitionBy instanceof Expr
+                ? $this->partitionBy->getExpression()
+                : $this->partitionBy;
         }
 
         if ($this->partitionByFields) {

diff --git a/tests/Doctrine/ODM/MongoDB/Tests/Aggregation/Stage/FillTest.php b/tests/Doctrine/ODM/MongoDB/Tests/Aggregation/Stage/FillTest.php
@@ -44,6 +44,30 @@ public function testStage(): void
         );
     }
 
+    public function testStageWithExpressionAsPartition(): void
+    {
+        $builder   = $this->getTestAggregationBuilder();
+        $fillStage = new Fill($builder);
+        $fillStage
+            ->partitionBy($builder->expr()->year('$field'))
+            ->sortBy('field1', 1)
+            ->output()
+                ->field('foo')->locf();
+
+        self::assertEquals(
+            [
+                '$fill' => (object) [
+                    'partitionBy' => ['$year' => '$field'],
+                    'sortBy' => (object) ['field1' => 1],
+                    'output' => (object) [
+                        'foo' => ['method' => 'locf'],
+                    ],
+                ],
+            ],
+            $fillStage->getExpression(),
+        );
+    }
+
     public function testStageWithComplexSort(): void
     {
         $fillStage = new Fill($this->getTestAggregationBuilder());