Address or ignore deprecations #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jan 11, 2022
| # Switch to Logging\Connection after dropping compatibility with DBAL 2 | ||
| - | ||
| message: '~deprecated.*DebugStack~' | ||
| path: tests/Doctrine/Migrations/Tests/Metadata/Storage/TableMetadataStorageTest.php |
There was a problem hiding this comment.
This test relies on the DebugStack to determine how many queries were performed.
greg0ire
commented
Jan 11, 2022
| @@ -23,3 +23,14 @@ parameters: | |||
| - tests/Doctrine/Migrations/Tests/Tools/Console/legacy-config-dbal/cli-config.php | |||
| - tests/Doctrine/Migrations/Tests/Tools/Console/legacy-config-wrong/cli-config.php | |||
|
|
|||
| # We need to implement platform-aware comparison | |||
There was a problem hiding this comment.
This seems to impactful to do in this pull request. Not sure it would qualify as a bugfix either (but then neither does addressing a deprecation if you ask me).
There was a problem hiding this comment.
Keeping track of this at #1227
greg0ire
force-pushed
the
fix-build
branch
2 times, most recently
from
687674b to
0b37cf2
Compare
stof
reviewed
Jan 11, 2022
It should be noted that this changes the generated SQL inside migrations so that it does not generate code that triggers deprecations.
|
this seems to close #1218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It should be noted that this changes the generated SQL inside migrations
so that it does not generate code that triggers deprecations.
Closes #1218