Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures that Tights, and Shorts and Blouse are single/pluralised properly #202

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

powellblyth
Copy link
Contributor

Ensures that Tights, and Shorts are never singularised in English, ensures that Blouses is never singularised to Blice.

Previously, "Shorts" would singularise to "Short", but I still have "one pair of shorts"
Previously, "Tights" would singularise to "Tight", but I still have "one pair of tights"
Previously, "Blouses" would singularise to "Blice", but that word is meaningless in english

…sures that Blouses is never singularised to Blice
@derrabus
Copy link
Member

derrabus commented Sep 6, 2022

Can you please add your test cases to EnglishFunctionalTest?

@powellblyth
Copy link
Contributor Author

Can you please add your test cases to EnglishFunctionalTest?

Ah yes no problem. Sorry I didn’t find the best place to put those in. I’ll try and sort this tonight

@powellblyth
Copy link
Contributor Author

Hi, I've added the tests.

I notice there's a LOT of duplicates.. e.g. Moose is in there 3 times.

Would you like a PR deduping these? Or am I missing something?

@derrabus
Copy link
Member

derrabus commented Sep 7, 2022

I notice there's a LOT of duplicates.. e.g. Moose is in there 3 times.

Looks like this happened in #101 (cc @jwage). From my point of view, all those duplicates do is causing the same test to be executed multiple times. I think, we can delete them.

@derrabus derrabus added this to the 2.0.5 milestone Sep 7, 2022
@derrabus derrabus added the Bug label Sep 7, 2022
@derrabus derrabus merged commit ade2b3b into doctrine:2.0.x Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants