-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: PHP 7.0 nightly added #809
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1159 We use Jira to track the state of pull requests and the versions they got |
env: DB=pgsql POSTGRESQL_VERSION=9.2 # driver currently unsupported by HHVM | ||
- php: hhvm-nightly | ||
env: DB=pgsql POSTGRESQL_VERSION=9.3 # driver currently unsupported by HHVM | ||
- php: 7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are excluding all PHP 7 builds here again, meaning your change does not add them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's wrong section. I didn't notice. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
👍 |
👍 as well |
👍 |
Also fixed standard to 2 spaces, that's used above