Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: PHP 7.0 nightly added #809

Merged
merged 1 commit into from
Mar 2, 2015
Merged

travis: PHP 7.0 nightly added #809

merged 1 commit into from
Mar 2, 2015

Conversation

TomasVotruba
Copy link
Contributor

Also fixed standard to 2 spaces, that's used above

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1159

We use Jira to track the state of pull requests and the versions they got
included in.

env: DB=pgsql POSTGRESQL_VERSION=9.2 # driver currently unsupported by HHVM
- php: hhvm-nightly
env: DB=pgsql POSTGRESQL_VERSION=9.3 # driver currently unsupported by HHVM
- php: 7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are excluding all PHP 7 builds here again, meaning your change does not add them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's wrong section. I didn't notice. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@stof
Copy link
Member

stof commented Mar 2, 2015

👍

@Ocramius Ocramius self-assigned this Mar 2, 2015
Ocramius added a commit that referenced this pull request Mar 2, 2015
travis: PHP 7.0 nightly added
@Ocramius Ocramius merged commit a5e885a into doctrine:master Mar 2, 2015
@Ocramius
Copy link
Member

Ocramius commented Mar 2, 2015

👍 as well

@TomasVotruba
Copy link
Contributor Author

👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants