Remove final constructor for Type

[ruudk]

Q	A
Type	improvement
Fixed issues	#6704

Summary

This allows people to define a constructor when creating custom Doctrine\DBAL\Types\Type implementations.

They can only be registered using Type::getTypeRegistry()->register and not with Type::addType.

An extra guard in Type::addType explains this to the user.

[greg0ire]

Note: this is another take on #5528

[morozov]

I've never used custom types as besides schema management, they are primarily designed for the ORM. I'll defer to Alexander.

[derrabus]

If we do that, we turn Type::addType() into a potential footgun. Maybe it's time to deprecate the static methods on the Type class in favor of the TypeRegistry?

[ruudk]

If we do that, we turn Type::addType() into a potential footgun.

How will it be a potential footgun? The current desired behavior is guarded, so I don't see how.

Maybe it's time to deprecate the static methods on the Type class in favor of the TypeRegistry?

I agree, but that can be done independently from this PR, no?

[derrabus]

If we do that, we turn Type::addType() into a potential footgun.

How will it be a potential footgun? The current desired behavior is guarded, so I don't see how.

Yes, you've done all you could to give the developer proper feedback. Yet, we're about to create a class of types that cannot be registered with Type::addType() anymore, an issue which is only discoverable at runtime.

Maybe it's time to deprecate the static methods on the Type class in favor of the TypeRegistry?

I agree, but that can be done independently from this PR, no?

Sure, but still we should talk about it. We somehow ended up with an only partially implemented feature and I want us to work towards a proper solution this time instead of adding a small hack on top to make it somewhat work.

[ruudk]

@derrabus @greg0ire You're right. Let's deprecate Type::addType immediately. Updated the PR.

[greg0ire]

It seems the tests I wrote in my initial PR were not sufficient to prove it's possible to do what's in the documentation. Maybe they should be improved?

[greg0ire]

The docs should be updated, they mention addType.