Move schema part to the index

[greg0ire]

In SQLite, creating an index in another schema is done by prepending the
index name with the schema, while the table name must be unprefixed.

See https://www.sqlite.org/lang_createindex.html

[greg0ire]

This is prompted by doctrine/data-fixtures#452 , and now I think my PR looks so wrong that the issue must be somewhere else.

[greg0ire]

Actually, reopening, because my tests don't involve the ORM and should really work. So maybe the fix is wrong, but I don't see how the tests are.

[morozov]

I would not introduce this test. We do not care what the resulting SQL looks like as long as the functionality is covered by a test. Furthermore, this test is definitely not the source of truth about what the index name should be.

[derrabus]

The problem is that the functional test would pass if the platform decided to create no index at all.

I agree about the generated name though. If we make assertions on the name if the index, we should explicitly declare a name for the index.

[greg0ire]

Should I remove the unit test and modify the functional test to assert that an index does exist? If the platform decides not to create it, then introspecting the table won't show the index.

[greg0ire]

Actually, I stand corrected. This fails for some reason 🤯 :

        $onlineTable = $this->connection->createSchemaManager()->introspectTable('other.test_other_schema');
        self::assertTrue($onlineTable->hasIndex('id'));

Doctrine\DBAL\Schema\Exception\TableDoesNotExist: There is no table with name "other.test_other_schema" in the schema.

I think there must be another bug. Or maybe it's just that it's not supported. If I use a separate connection, it works.

[morozov]

If we need to ensure that the index exists, we can introspect the schema.

[greg0ire]

Yep I think I did exactly that:)

[derrabus]

Thank you @greg0ire!