Remove API to disable column comments

psalm.xml.dist

@@ -77,6 +77,8 @@
                 <file name="src/Schema/Column.php"/>
                 <!-- See https://github.com/vimeo/psalm/issues/5472 -->
                 <file name="src/Portability/Converter.php"/>
+                <!-- We're checking for invalid input -->
+                <file name="src/Configuration.php"/>
             </errorLevel>
         </DocblockTypeContradiction>
         <FalsableReturnStatement>

src/Configuration.php

@@ -5,6 +5,7 @@
 namespace Doctrine\DBAL;
 
 use Doctrine\DBAL\Driver\Middleware;
+use Doctrine\DBAL\Exception\InvalidArgumentException;
 use Doctrine\DBAL\Schema\SchemaManagerFactory;
 use Psr\Cache\CacheItemPoolInterface;
 
@@ -33,14 +34,6 @@
      */
     protected bool $autoCommit = true;
 
-    /**
-     * Whether type comments should be disabled to provide the same DB schema than
-     * will be obtained with DBAL 4.x. This is useful when relying only on the
-     * platform-aware schema comparison (which does not need those type comments)
-     * rather than the deprecated legacy tooling.
-     */
-    private bool $disableTypeComments = false;
-
     private ?SchemaManagerFactory $schemaManagerFactory = null;
 
     public function __construct()
@@ -141,15 +134,22 @@
         return $this;
     }
 
+    /** @return true */
     public function getDisableTypeComments(): bool
     {
-        return $this->disableTypeComments;
+        return true;
     }
 
-    /** @return $this */
+    /**
+     * @param true $disableTypeComments
+     *
+     * @return $this
+     */
     public function setDisableTypeComments(bool $disableTypeComments): self
     {
-        $this->disableTypeComments = $disableTypeComments;
+        if (! $disableTypeComments) {
+            throw new InvalidArgumentException('Column comments cannot be enabled anymore.');
+        }
 
         return $this;
     }

src/Connection.php

@@ -188,7 +188,6 @@ public function getDatabasePlatform(): AbstractPlatform
             }
 
             $this->platform = $this->driver->getDatabasePlatform($versionProvider);
-            $this->platform->setDisableTypeComments($this->_config->getDisableTypeComments());
         }
 
         return $this->platform;

src/Platforms/AbstractPlatform.php

@@ -81,14 +81,6 @@ abstract class AbstractPlatform
      */
     protected ?KeywordList $_keywords = null;
 
-    private bool $disableTypeComments = false;
-
-    /** @internal */
-    final public function setDisableTypeComments(bool $value): void
-    {
-        $this->disableTypeComments = $value;
-    }
-
     /**
      * Returns the SQL snippet that declares a boolean column.
      *