Relax return types of getExceptionConverter() implementations #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 14, 2023
| @@ -52,7 +53,7 @@ public function getDatabasePlatform(ServerVersionProvider $versionProvider): Abs | |||
| return new MySQLPlatform(); | |||
| } | |||
|
|
|||
| public function getExceptionConverter(): ExceptionConverter | |||
| public function getExceptionConverter(): ExceptionConverterInterface | |||
There was a problem hiding this comment.
This one was not narrowed in #4926, it's just as narrow on 3.x… I think it's fine not to document that change as breaking since ExceptionConverter is internal.
There was a problem hiding this comment.
No, the type is wider on 3.x.
dbal/src/Driver/AbstractMySQLDriver.php
Lines 200 to 203 in 2caad21
I'm restoring the 3.x return type declaration.
greg0ire
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This takes back a change I made with #4926. If I want to implement a new let's say MySQL driver that uses a custom exception converter, I'm forced to extend the MySQL exception converter which feels too restrictive.
Background: I maintain a custom ODBC driver for DBAL and since ODBC has its own error codes, the MySQL exception converter is useless for me in that context.