Merge 3.8.x into 4.0.x #6218
Merged
Merge 3.8.x into 4.0.x #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |------------- | ----------- | Type | bug | Fixed issues | contao/contao#6409 #### Summary Starting with version 3.7.0 we noticed that the `listTableColumns()` method got very slow on some systems, our migrate command went from taking around 2 seconds with version 3.6 to 260 seconds with version3.7. This is due to the `LEFT JOIN information_schema.CHECK_CONSTRAINTS` not getting optimized by MariaDB which causes the database server to scan every table of every database. This pull request fixes that by using a subquery that is limited by `WHERE CONSTRAINT_SCHEMA = $databaseName`. This brings the performance back to where it was with version 3.6.
* 3.7.x: Fix MariaDB list columns performance (doctrine#6202)
…#6213) | Q | A |------------- | ----------- | Type | improvement | Fixed issues | doctrine#6202 (comment) #### Summary Deprecates `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` ~~Needs to be rebased after doctrine#6202 got merged upstream.~~ Done. --------- Co-authored-by: Alexander M. Turek <[email protected]>
…n layer (doctrine#6215) | Q | A |------------- | ----------- | Type | improvement | Fixed issues | Follows doctrine#6213 #### Summary We want to stop guessing the current database. cc @ausi
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | n/a #### Summary Latest Oracle database compatibility should be tested. Targetting lowest open branch to assert the compatibility for 3.7.x too for possible bugfixes.
* 3.7.x: Add Oracle v23 to CI testing (doctrine#6217)
Co-authored-by: Herberto Graca <[email protected]>
…options Enable skipping locked rows in QueryBuilder
|
DockerHub seems to have a little hiccup at the moment. |
* 3.8.x: Enable skipping locked rows in QueryBuilder Fix coding standard violation Remove unused unit test fixtures Add Oracle v23 to CI testing (doctrine#6217) Extend `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` deprecation layer (doctrine#6215) Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.