Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getJsonTypeDeclarationSQL() to AbstractMySQLPlatform #6216

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Move getJsonTypeDeclarationSQL() to AbstractMySQLPlatform #6216

merged 1 commit into from
Nov 6, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 5, 2023

Q A
Type improvement
Fixed issues N/A

Summary

Both MySQL dialects support the JSON column type, so let's move this method up to AbstractMySQLPlatform.

@derrabus derrabus added this to the 4.0.0-RC2 milestone Nov 5, 2023
@derrabus derrabus requested a review from greg0ire November 5, 2023 23:02
SenseException
SenseException approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@derrabus derrabus merged commit 8134e7c into doctrine:4.0.x Nov 6, 2023
68 checks passed
@derrabus derrabus deleted the improvement/mysql-json branch November 6, 2023 18:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Improvement MariaDB MySQL Platforms
Projects
None yet
Milestone
4.0.0-RC2
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @morozov @greg0ire @SenseException