Add a configuration setting to disable generating type comments #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to opt-in for a schema generated without type comments once the project is migrating to the new schema tooling that does not need them, allowing to have a clean DB schema without waiting for DBAL 4.0 and to decouple the schema migration from the DBAL upgrade itself.
|
I don't think so. The upgrade note is more for direct consumers of those APIs. But for most projects, those direct consumers are in the DBAL schema tool anyway. This new setting is something those projects can turn on once they have performed this upgrade. |
derrabus
approved these changes
Sep 14, 2023
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Sep 18, 2023
* 3.7.x: Run tests against Postgres 16 (doctrine#6154) PHPStan 1.10.34, PHPUnit 9.6.12 (doctrine#6151) Bump CI workflows (doctrine#6152) Add a configuration setting to disable generating type comments (doctrine#6150) Fix invalid SQL in the document docs: link to the testing guidelines in CONTRIBUTING.md Fix IBM DB2 tests Implement binary array parameter type Document `driverOptions` for SQL Server connections (doctrine#6140)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Sep 18, 2023
* 3.7.x: Run tests against Postgres 16 (doctrine#6154) PHPStan 1.10.34, PHPUnit 9.6.12 (doctrine#6151) Bump CI workflows (doctrine#6152) Add a configuration setting to disable generating type comments (doctrine#6150) Fix invalid SQL in the document docs: link to the testing guidelines in CONTRIBUTING.md Fix IBM DB2 tests Implement binary array parameter type Document `driverOptions` for SQL Server connections (doctrine#6140)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows to opt-in for a schema generated without type comments once the project is migrating to the new schema tooling that does not need them, allowing to have a clean DB schema without waiting for DBAL 4.0 and to decouple the schema migration from the DBAL upgrade itself.
I decided to name that field
disable*so that the opt-in for the new behavior is done by setting it totrue