Keep the length -1 in portable table column definition. Generate SQL … #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Snippen with NVARCHAR(MAX) for length -1.
|
Thanks for the contribution. Next to the needed coding style fixes there are tests missing for the added code to cover that this is doing what it's supposed to do. |
|
Closing because we haven't heard back from the author. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Snippet with NVARCHAR(MAX) for length -1.
The portable Column Definition keeps a length of -1 for nchar, nvarchar, ntext instead of dividing by 2.
A length of -1 is then considered in the sql varchar type decleration.