Fix test cases for URL parsing #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Dec 31, 2022
| @@ -113,6 +114,7 @@ public function testDatabaseUrlPrimaryReplica(): void | |||
| 'wrapperClass' => PrimaryReadReplicaConnection::class, | |||
| ]; | |||
|
|
|||
| $this->expectDeprecationWithIdentifier('https://github.com/doctrine/dbal/pull/5843'); | |||
There was a problem hiding this comment.
URLs for primary/replica have to be parsed in advance as well, so we do get the deprecation here.
derrabus
commented
Dec 31, 2022
Comment on lines
+188
to
+192
| if (isset($url['driverClass'])) { | ||
| self::markTestSkipped( | ||
| 'Legacy test case: Merging driverClass into the parsed parameters has to be done in userland now.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
We currently remove an explicitly configured driver class if the URL has a scheme. That might be unexpected because for all other parameters, it works the other way round. Since with the new parser, the app is in charge of that, we need to skip the corresponding tests.
derrabus
commented
Dec 31, 2022
| ['url' => $url] = $options = $url; | ||
| unset($options['url']); |
There was a problem hiding this comment.
If I don't unset the URL here, it's actually parsed twice which is why the driverClass tests still worked although they shouldn't have. 😓
greg0ire
approved these changes
Dec 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some issues with the tests I've overlooked. I'll get into details by commenting on the diff.