Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters of the diff-related methods #5768

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 16, 2022

Q A
Type improvement

The "from" and "to" prefixes of the diff-related method parameters and variable names are replaced with "old" and "new" respectively. They have equal lengths and are adjectives, which makes code more human-readable.

@morozov morozov added this to the 4.0.0 milestone Oct 16, 2022
@morozov morozov marked this pull request as ready for review October 16, 2022 22:30
@morozov morozov requested review from greg0ire and derrabus October 16, 2022 22:34
@morozov morozov merged commit 750c448 into doctrine:4.0.x Oct 17, 2022
@morozov morozov deleted the rename-diff-parameters branch October 17, 2022 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants