Remove TableDiff::$name and getName() #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
remove-table-diff-name
branch
2 times, most recently
from
367c09e to
39e4ff8
Compare
| @@ -1224,7 +1228,7 @@ public static function getGeneratesIdentifierNamesInAlterTableSQL(): iterable | |||
| // Quoted identifiers non-reserved keywords. | |||
| [ | |||
| new TableDiff( | |||
| '`mytable`', | |||
| new Table('mytable'), | |||
There was a problem hiding this comment.
Is this supposed to keep the `?
Suggested change
| new Table('mytable'), | |
| new Table('`mytable`'), |
There was a problem hiding this comment.
Thanks! The quotes got lost during refactoring.
| @@ -1300,7 +1304,7 @@ public static function getGeneratesIdentifierNamesInAlterTableSQL(): iterable | |||
| // Quoted identifiers reserved keywords. | |||
| [ | |||
| new TableDiff( | |||
| '`table`', | |||
| new Table('mytable'), | |||
There was a problem hiding this comment.
Is this supposed to keep the `?
Suggested change
| new Table('mytable'), | |
| new Table('`mytable`'), |
There was a problem hiding this comment.
The table name got accidentally changed during the refactoring but apparently, it's irrelevant to the test.
morozov
force-pushed
the
remove-table-diff-name
branch
from
39e4ff8 to
6381aca
Compare
greg0ire
approved these changes
Sep 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API being removed was deprecated in #5678.
Additionally, this patch makes the reference from the table diff to the old table mandatory. In order to do that, it moves the corresponding constructor argument from the last position to the first, since all remaining arguments are still optional. This change should not affect the consumers of the DBAL API since the constructor is internal.