Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and mark internal APIs related to schema comparison #5650

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 3, 2022

  1. ColumnDiff::$changedProperties, ::hasChanged() and Comparator::diffColumn() are being deprecated as they implement the legacy property-based schema comparison API and will be removed in Remove property-based schema comparison APIs #5649.
  2. Comparator::columnsEqual(), ::diffForeignKey() and ::diffIndex() are being marked as internal as they are only used within the comparator as part of ::diffTable(). The corresponding objects can only exist as part of their tables and should be compared as part of the table comparison.

@morozov morozov added this to the 3.5.0 milestone Sep 3, 2022
@morozov morozov marked this pull request as ready for review September 3, 2022 07:28
@morozov morozov requested review from greg0ire and derrabus September 3, 2022 07:29
@morozov morozov merged commit e5e8607 into doctrine:3.5.x Sep 3, 2022
@morozov morozov deleted the deprecate-comparator-apis branch September 3, 2022 17:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants