Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use ColumnDiff::$changedProperties in SQLServerPlatform::getAlterTableSQL() #5640

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 1, 2022

Similar to #5623, instead of counting changed properties, check whether the resulting column declaration has changed.

@morozov morozov added this to the 4.0.0 milestone Sep 1, 2022
@morozov morozov marked this pull request as ready for review September 1, 2022 02:40
@morozov morozov requested a review from greg0ire September 1, 2022 02:40
@morozov morozov merged commit 2ed2ac1 into doctrine:4.0.x Sep 1, 2022
@morozov morozov deleted the sql-server-alter-table-cleanup branch September 1, 2022 14:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants