Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test scenarios related to altering columns #5629

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 29, 2022

  1. Remove leftovers of AbstractPlatformTestCase::testAlterTableColumnComments() removed in Merge 3.5.x up into 4.0.x #5626.
  2. Remove AbstractPlatformTestCase::testCreateTableColumnComments(). The corresponding functionality is covered in greater detail in the functional ColumnCommentTest.
  3. Add a functional replacement for PostgreSQLPlatformTest::testAlterDecimalPrecisionScale() removed in Merge 3.5.x up into 4.0.x #5626. Now altering decimal columns is covered with a single test across all supported platforms.

Closes #5627.

@morozov morozov added this to the 4.0.0 milestone Aug 29, 2022
@morozov morozov linked an issue Aug 29, 2022 that may be closed by this pull request
@morozov morozov marked this pull request as ready for review August 29, 2022 18:28
@morozov morozov requested a review from greg0ire August 29, 2022 18:28
@morozov morozov merged commit 035b4a8 into doctrine:4.0.x Aug 29, 2022
@morozov morozov deleted the issues/5627 branch August 29, 2022 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit removed tests on 4.0.x
2 participants