Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positive outcomes:
UnknownParameterType
exception is no longer possible since all possible values of the parameter type are constrained by the enum.int
type are now distinct (ParameterType
andint
respectively). This is important since the wrapper-level array types have non-obviously limited support. For instance, they can be used inConnection::executeQuery()
but not inStatement::bindValue()
.Negative outcomes:
As the next step, we can simplify the type of parameter types by making them non-nullable. There is already a default of "string" (see #5550).
TODO: