Deprecate passing date interval parameters as integers #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
morozov
force-pushed
the
deprecate-date-int-intervals
branch
from
76036d8 to
7eb9b42
Compare
greg0ire
reviewed
May 8, 2022
| * @param string $date | ||
| * @param int $seconds | ||
| * @param string $date | ||
| * @param int|numeric-string $seconds |
There was a problem hiding this comment.
If the string is supposed to be numeric, and SQL expressions are not possible here, is there still a point to that API change? It seems less convenient to use strings here. What am I missing?
There was a problem hiding this comment.
It is needed for the API consumer to be able to pass strings instead of integers in order to be compatible with both DBAL 3 and 4.
See doctrine/orm#9742 for more details.
greg0ire
approved these changes
May 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API will change in 4.0 (#3498).