Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return number of affected rows greater than PHP_INT_MAX as string #5274

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Return number of affected rows greater than PHP_INT_MAX as string #5274

merged 1 commit into from
Feb 13, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Feb 13, 2022

Q A
Type improvement

If the number of affected rows is greater than PHP_INT_MAX, it should be returned as a string.

@morozov morozov added this to the 4.0.0 milestone Feb 13, 2022
@morozov morozov requested review from derrabus and greg0ire February 13, 2022 20:14
@morozov morozov merged commit defa28e into doctrine:4.0.x Feb 13, 2022
@morozov morozov deleted the affected-rows-as-string branch February 13, 2022 21:38
@greg0ire greg0ire mentioned this pull request Jan 28, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
BC Break Improvement Prepared Statements
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire