Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native IBM DB2 11 syntax for Top-N queries #5156

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 31, 2021

Q A
Type improvement
BC Break no

IBM DB2 supports the MySQL syntax without additional configuration as of release 11.1 (source):

0x4000 (obsolete) This bit formerly activated LIMIT and OFFSET support, but that feature is now always active and this bit is now ignored.

UPD: it doesn't seem to support OFFSET without a LIMIT in the MySQL syntax but it supports the Oracle's one.
UPD: I also checked that IBM DB2 10.5 (implicitly supported in DBAL 3.x) also supports the FETCH n ROWS ONLY clause but doesn't support the OFFSET n ROWS clause, so this patch can be only accepted for DBAL 4.0.

@morozov morozov marked this pull request as ready for review January 1, 2022 03:14
@morozov morozov requested review from derrabus and greg0ire January 2, 2022 15:25
@morozov morozov merged commit 27a7c5b into doctrine:4.0.x Jan 5, 2022
@morozov morozov deleted the ibm-db2-limit branch January 5, 2022 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants