Remove Platform API about commented types #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type::requiresSQLCommentHint() already does the job.
greg0ire
force-pushed
the
drop-comment-api
branch
from
8924038 to
77427c5
Compare
greg0ire
requested review from
derrabus and
morozov
and removed request for
derrabus
|
This may invalidate #4983. Could you check, please? |
morozov
approved these changes
Dec 1, 2021
|
@morozov I think it would, and I also think I can work on fixing it on 3.2.x (by porting the change in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type::requiresSQLCommentHint()already does the job.