Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for SQL Server 2016 and older #4860

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 11, 2021

The mainstream support has ended (source).

@morozov morozov added this to the 4.0.0 milestone Oct 11, 2021
@morozov morozov force-pushed the drop-sql-server-2016 branch from 7482ad5 to 3055def Compare October 11, 2021 14:48
@morozov morozov marked this pull request as ready for review October 11, 2021 14:56
@morozov morozov requested a review from derrabus October 11, 2021 14:57
@derrabus
Copy link
Member

Shall we rename SQLServer2012Platform to SQLServer2017Platform then?

@derrabus
Copy link
Member

… or deprecate&drop SQLServer2012Platform completely? The name of the class is highly confusing, we only support 2017 and onwards.

@morozov
Copy link
Member Author

morozov commented Oct 11, 2021

SQLServer2012Platform was removed in #4763. Now, SQLServerPlatform is explicitly documented as:

/**
* Provides the behavior, features and SQL dialect of the Microsoft SQL Server database platform
* of the oldest supported version.
*/

We decided not to have a version in the class name representing the oldest supported version. It will help avoid extra diffs when dropping old platforms, also #4755 (comment).

@derrabus
Copy link
Member

Oh, I didn't see that. 🙈

@morozov morozov merged commit e20d809 into doctrine:4.0.x Oct 11, 2021
@morozov morozov deleted the drop-sql-server-2016 branch October 11, 2021 17:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants