Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $name from AbstractPlatform object declaration methods #4806

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Remove $name from AbstractPlatform object declaration methods #4806

merged 1 commit into from
Sep 19, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 19, 2021

Q A
Type improvement
BC Break yes

Summary

The object name is already available as part of the object, no need to pass/accept it as a separate value.

@morozov morozov added this to the 4.0.0 milestone Sep 19, 2021
@morozov morozov marked this pull request as ready for review September 19, 2021 19:29
@morozov morozov requested a review from greg0ire September 19, 2021 19:29
@morozov morozov merged commit 0c9fc84 into doctrine:4.0.x Sep 19, 2021
@morozov morozov deleted the remove-object-name-parameter branch September 19, 2021 20:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Indexes Platforms
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire