Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare abstract methods in AbstractPlatform as abstract #4723

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Declare abstract methods in AbstractPlatform as abstract #4723

merged 1 commit into from
Jul 20, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 20, 2021

Q A
Type improvement
BC Break yes

All affected methods are applicable to all supported platforms, so the default implementation contains the code that cannot be executed which effectively makes them abstract.

@morozov morozov added this to the 4.0.0 milestone Jul 20, 2021
@morozov morozov marked this pull request as ready for review July 20, 2021 01:05
@morozov morozov requested a review from greg0ire July 20, 2021 01:06
@morozov morozov merged commit 2b0f79c into doctrine:4.0.x Jul 20, 2021
@morozov morozov deleted the platform-abstract-methods branch July 20, 2021 15:28
@morozov morozov mentioned this pull request Dec 19, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Improvement Platforms
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire