Introduce consistent Comparator API #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m not sure if I understand this change. Wouldn’t it make merging #4659 way harder if we have to keep backwards compatibility there with the new method names from this pull request? |
morozov
reviewed
Jul 10, 2021
There was a problem hiding this comment.
@trompette, the patch looks good overall. Please see a few suggestions inline.
tests/Functional/Platform/NewPrimaryKeyWithNewAutoIncrementColumnTest.php
Outdated
Show resolved
Hide resolved
morozov
reviewed
Jul 11, 2021
morozov
reviewed
Jul 11, 2021
morozov
reviewed
Jul 11, 2021
trompette
force-pushed
the
consistent-comparator-api
branch
from
195fbfc to
acb6c52
Compare
morozov
reviewed
Jul 12, 2021
trompette
force-pushed
the
consistent-comparator-api
branch
from
acb6c52 to
e623041
Compare
morozov
reviewed
Jul 12, 2021
trompette
force-pushed
the
consistent-comparator-api
branch
3 times, most recently
from
f8eb927 to
8430837
Compare
morozov
previously approved these changes
Jul 12, 2021
|
Sorry, one last thing. We'll need to add a note to |
trompette
force-pushed
the
consistent-comparator-api
branch
from
8430837 to
10f1c6a
Compare
This commit deprecates: - calls to compare(), and - static calls to compareSchemas().
trompette
force-pushed
the
consistent-comparator-api
branch
from
10f1c6a to
dda7bf9
Compare
morozov
approved these changes
Jul 13, 2021
|
Thanks, @trompette! |
|
@trompette if you fancy, you can go ahead and file another PR that removes the deprecated APIs from |
trompette
added a commit
to trompette/dbal
that referenced
this pull request
Jul 16, 2021
The method has been deprecated and scheduled for removal since doctrine#4707.
|
@morozov, done! 😉 |
trompette
added a commit
to trompette/dbal
that referenced
this pull request
Jul 16, 2021
The method has been deprecated and scheduled for removal since doctrine#4707.
trompette
added a commit
to trompette/dbal
that referenced
this pull request
Jul 16, 2021
The method has been deprecated and scheduled for removal since doctrine#4707.
trompette
added a commit
to trompette/dbal
that referenced
this pull request
Jul 16, 2021
The method has been deprecated and scheduled for removal since doctrine#4707.
chalasr
added a commit
to symfony/symfony
that referenced
this pull request
Jul 14, 2022
This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Fix calls to deprecated DBAL methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follows doctrine/dbal#4746 and doctrine/dbal#4707. Commits ------- 2f834f2 [Messenger] Fix calls to deprecated DBAL methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates previous
ComparatorAPI and replaces it with a more consistent one.For more information, see: