Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Psalm to 4.8.1 #4699

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Update Psalm to 4.8.1 #4699

merged 1 commit into from
Jul 3, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 2, 2021

Q A
Type bug
BC Break mostly no

Summary

While we did most of the argument names cleanup in #4172, the updated Psalm flagged some more cases. Since we already support PHP 8, changing argument names could be technically called out as a BC break, I believe this change is acceptable:

  1. The argument names are inconsistent across implementations, so the current state cannot be considered correct.
  2. All changes are made in the methods that accept a single argument, so it's very unlikely that the calling side passes the argument by name.

@SenseException
Copy link
Member

The inconsistent naming was also a BC break, so this would fix some issues.

@morozov morozov merged commit ce15957 into doctrine:2.13.x Jul 3, 2021
@morozov morozov deleted the psalm-4.8.1 branch July 3, 2021 15:40
@morozov morozov added this to the 2.13.3 milestone Jul 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants