Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4681] Remove TableGenerator #4692

Merged
merged 1 commit into from
Jun 26, 2021
Merged

[GH-4681] Remove TableGenerator #4692

merged 1 commit into from
Jun 26, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 26, 2021

Q A
Type improvement
BC Break yes

See #4681.

@morozov morozov marked this pull request as ready for review June 26, 2021 03:05
@morozov morozov requested a review from greg0ire June 26, 2021 03:05
greg0ire
greg0ire previously approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletion comes with a nice coverage increase 🙂 (+0.38%)

@morozov morozov closed this Jun 26, 2021
@morozov morozov deleted the remove-table-generator branch June 26, 2021 14:28
@morozov morozov restored the remove-table-generator branch June 26, 2021 14:29
@morozov morozov reopened this Jun 26, 2021
@morozov morozov force-pushed the remove-table-generator branch from 6d1e78f to 076ff60 Compare June 26, 2021 14:31
@morozov
Copy link
Member Author

morozov commented Jun 26, 2021

Often, it's the runtime deprecation code that is not covered by tests. But in this case, it's in the constructors which are covered. Let's see if we can eventually get to 90% coverage.

@morozov morozov requested a review from greg0ire June 26, 2021 14:41
@morozov morozov merged commit c242a4f into doctrine:4.0.x Jun 26, 2021
@morozov morozov deleted the remove-table-generator branch June 26, 2021 15:36
@morozov morozov added this to the 4.0.0 milestone Jun 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
BC Break Sequences
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire